Skip to content

deps: V8: cherry-pick 1d7159580156#58749

Closed
targos wants to merge 1 commit intonodejs:mainfrom
targos:v8-erm-fixes
Closed

deps: V8: cherry-pick 1d7159580156#58749
targos wants to merge 1 commit intonodejs:mainfrom
targos:v8-erm-fixes

Conversation

@targos
Copy link
Member

@targos targos commented Jun 18, 2025

Original commit message:

[explicit-resource-management] Clear isolate internal exception

This CL clears the isolate internal exception before rejecting
the promise.

Bug: 418103036
Change-Id: If3748f7fc4b79b7b5be5009b9fff0d0267541a6f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6594252
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#100532}

Refs: v8/v8@1d71595

@targos
deps: V8: cherry-pick 1d7159580156
c94d994 
Original commit message:

    [explicit-resource-management] Clear isolate internal exception

    This CL clears the isolate internal exception before rejecting
    the promise.

    Bug: 418103036
    Change-Id: If3748f7fc4b79b7b5be5009b9fff0d0267541a6f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6594252
    Reviewed-by: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#100532}

Refs: v8/v8@1d71595
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2025

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jun 18, 2025
@targos targos added dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Jun 18, 2025
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67520/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6616/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6616/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 18, 2025

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6616/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 19, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67529/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 20, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67564/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 22, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67603/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 30, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67749/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 1, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67764/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67794/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 3, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67812/

targos added a commit that referenced this pull request Jul 3, 2025
@targos
deps: V8: cherry-pick 1d7159580156
8db664f 
Original commit message:

    [explicit-resource-management] Clear isolate internal exception

    This CL clears the isolate internal exception before rejecting
    the promise.

    Bug: 418103036
    Change-Id: If3748f7fc4b79b7b5be5009b9fff0d0267541a6f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6594252
    Reviewed-by: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#100532}

Refs: v8/v8@1d71595
PR-URL: #58749
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos
Copy link
Member Author

targos commented Jul 3, 2025

Landed in 8db664f

@targos targos closed this Jul 3, 2025
@targos targos deleted the v8-erm-fixes branch July 3, 2025 15:38
targos added a commit that referenced this pull request Jul 3, 2025
@targos
deps: V8: cherry-pick 1d7159580156
bf66291 
Original commit message:

    [explicit-resource-management] Clear isolate internal exception

    This CL clears the isolate internal exception before rejecting
    the promise.

    Bug: 418103036
    Change-Id: If3748f7fc4b79b7b5be5009b9fff0d0267541a6f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6594252
    Reviewed-by: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#100532}

Refs: v8/v8@1d71595
PR-URL: #58749
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Jul 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@targos @nodejs-github-bot @jasnell @lpinca @richardlau @legendecas @RafaelGSS